LookAndFeel requests

[jules]

The ResizableWindow already has a way of specifying the background colour, and doesn't draw any text, so not sure about why you need those..

And for a tabbed component, it lets you change the colour of each tab individually, so a global tab colour doesn't really apply. I guess it could let you set a default tab colour, but that would involve changing the addTab method to remove the colour parameter, and breaking a lot of code.

[photon]

The minimum height of a menu item is restricted in PopupMenuWindow::addItem() by:

Code: Select all

mic->setSize (itemW, jlimit (10, 600, itemH));

I would like to have that minimum height set to 1px (but that may break someones menus), or be configurable by the LookAndFeel:

Code: Select all

LookAndFeel::getMinimumPopupMenuItemSize (int &minimumWidth, int &minimumHeight);

I hit this minimal height limit, because I want menu separators to be smaller than 10px in my custom LookAndFeel.

[jules]

It does seem a bit hard-coded, and could easily be less than 10 without doing any harm, I think. I doubt if there are any custom components that set their size to less than 10..

[mdsp]

I'd like to create a subclass of MidiKeyboardComponent that would delegate its drawing to a custom LnF however I can't because MidiKeyboardComponent::getKeyPos is private.
protected or friend class LookAndFeel should be enough for me.

If you feel like factoring the drawing code from MidiKeyboardComponent into the LookAndFeel I'm all for it too.

[jules]

Can't you do what you need with drawUpDownButton(), getKeyPosition(), etc?

[mdsp]

ah sorry I didn't see getKeyPosition(), thanks

[0746]

I'd appreciate some color ids for table header

[spiderman]

Jules, a while back you extended the AlertWindow class so you can now change the button height and text font. The button height works fine, but still cannot set change the font. If I'm not mistaken, it works only for named texteditor and combo components. So:

* please make font change fwork for message and title
* or better yet, make the title and message string accessible (getTitle, getMessage) for flexible painting

While at the subject, would it be possible to add a setFont method to all the components with text? GroupComponent, TextEditor, etc. Perhaps even a font member and a Component::setFont just in case the comp wants to write something.

Thanks,
LB

[jules]

There's a LookAndFeel::getAlertWindowFont() method that you should be using for this. It's really a design decision that things like fonts belong in the l+f, and shouldn't be a property of the individual components.

[spiderman]

There's a LookAndFeel::getAlertWindowFont() method that you should be using for this. It's really a design decision that things like fonts belong in the l+f, and shouldn't be a property of the individual components.

I know, but it doesn't work for me. Will doublecheck it though.

Yes, it's two different concepts, but I thought a couple of extra public functions don't hurt. Use them, or rely on the defaults.

[spiderman]

There's a LookAndFeel::getAlertWindowFont() method that you should be using for this. It's really a design decision that things like fonts belong in the l+f, and shouldn't be a property of the individual components.

I know, but it doesn't work for me. Will doublecheck it though.

Yes, it's two different concepts, but I thought a couple of extra public functions don't hurt. Use them, or rely on the defaults.

Well, let me rephrase that. The real reason is to be able to put components of the same class on a window and give them different emphasis or set some of them to monospaced etc. So this is a real life thing, not just l'art pour l'art. But I can certainly live without it, so I hereby surrender

[jules]

Well, let me rephrase that. The real reason is to be able to put components of the same class on a window and give them different emphasis or set some of them to monospaced etc. So this is a real life thing, not just l'art pour l'art. But I can certainly live without it, so I hereby surrender Smile

Well, you don't have to live without it - just give each component a different l+f.

[amcleran]

Apart fom LookAndFeel, it would be cool if one could assign an integer tag/id to each component and retrieve the component based upon that tag/id.

Since you are probably always creating subclasses of Component, why can't you do this yourself? You could pass in the id value into your component during the constructor or with setter/getter methods.

Or, if you wanted to have all your components aware of each other, automatically setting unique ids for each of them, you could create a subclass of component with a static data member that increments each time the constructor is called -- then you make subclasses of this subclass, each sharing the static id, setting their own internal id number to the current id in their own constructors.

[amcleran]

Or, if you wanted to have all your components aware of each other, automatically setting unique ids for each of them, you could create a subclass of component with a static data member that increments each time the constructor is called -- then you make subclasses of this subclass, each sharing the static id, setting their own internal id number to the current id in their own constructors.

Better yet, you could make a simple class whose entire function is keep track of a class-wide static data member, then just inherit from it (since we can do multiple inheritance in C++) whenever you want a particular object (or component) to have a unique ID.

[yfede]

I'd like the DocumentWindow::getBorderSize () method to be a protected virtual method instead of a private one. That way, I may decide to have a border size of choiche for my subclasses of DocumentWindow.