Adding a framework changes 1000 lines
17 posts
• Page 1 of 2 • 1, 2
Adding a framework changes 1000 lines
by TheVinn » Fri Jun 15, 2012 7:32 am
All I did was add a few frameworks to an OS X export target in IntroJucer, and it ended up rewriting AppConfig.h, JuceHeader.h, the Makefile, the Visual Studio project file, and the .rc file. Why?
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by jules » Fri Jun 15, 2012 8:14 am
Why?
Why not? Why does it matter how many lines were changed?
-
jules - Fearless Leader
- Posts: 17364
- Joined: Mon Sep 06, 2004 9:03 am
- Location: London, UK
Re: Adding a framework changes 1000 lines
by TheVinn » Fri Jun 15, 2012 3:15 pm
jules wrote:Why not? Why does it matter how many lines were changed?
Because files unrelated to the change appear as if they were modified in the commit log. For example, I just opened up the .jucer file to add a few linker flags to the Makefile export target. Then I press "save" and now resources.rc, the .vcxproj, and the .pbxproj appear modified to git status.
Why should files unrelated to the change get modified?
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by jules » Fri Jun 15, 2012 3:39 pm
Why should files unrelated to the change get modified?
It doesn't just change files randomly. If something got changed in a file, then presumably the code is there for a reason.
-
jules - Fearless Leader
- Posts: 17364
- Joined: Mon Sep 06, 2004 9:03 am
- Location: London, UK
Re: Adding a framework changes 1000 lines
by TheVinn » Fri Jun 15, 2012 3:48 pm
jules wrote:It doesn't just change files randomly. If something got changed in a file, then presumably the code is there for a reason.
I agree, my presumption is that there is a reason for the change. But I can't find it. Check out this commit:
https://github.com/vinniefalco/DSPFilte ... 6889adeae3
All I did was modify the .jucer file to add some frameworks to the OS X targets. Of course the .pbxproj is different since we expect it to have the new frameworks added. But the .vcxproj changed as well, along with everything else produced by IntroJucer. Is this expected behavior?
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by jules » Fri Jun 15, 2012 5:04 pm
Just looks to me like your diff tool just did a crap job, making it *look* like everything's changed, when in fact not much really has.
-
jules - Fearless Leader
- Posts: 17364
- Joined: Mon Sep 06, 2004 9:03 am
- Location: London, UK
Re: Adding a framework changes 1000 lines
by TheVinn » Fri Jun 15, 2012 5:28 pm
jules wrote:Just looks to me like your diff tool just did a crap job, making it *look* like everything's changed, when in fact not much really has.
Fair enough. So let's forget about the quantity of the change and instead focus on the quality. Why should the Visual Studio projects have changed at all?
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by jules » Fri Jun 15, 2012 5:33 pm
Why should the Visual Studio projects have changed at all?
I don't know, but surely if you look at what the differences are, that'll answer your question? Maybe I updated the introjucer since the last time you generated those files.
-
jules - Fearless Leader
- Posts: 17364
- Joined: Mon Sep 06, 2004 9:03 am
- Location: London, UK
Re: Adding a framework changes 1000 lines
by TheVinn » Fri Jun 15, 2012 5:33 pm
jules wrote:I don't know, but surely if you look at what the differences are, that'll answer your question? Maybe I updated the introjucer since the last time you generated those files.
I don't see any difference. Could it be line endings?
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by jules » Fri Jun 15, 2012 7:04 pm
Could it be line endings?
Yeah, maybe.
-
jules - Fearless Leader
- Posts: 17364
- Joined: Mon Sep 06, 2004 9:03 am
- Location: London, UK
Re: Adding a framework changes 1000 lines
by jfitzpat » Sat Jun 16, 2012 1:59 am
A lot depends on how you have .gitconfig setup. I generally don't get line endings and whitespace showing up as false commits.
-jjf
-jjf
-
jfitzpat - JUCE UberWeenie
- Posts: 251
- Joined: Tue Jan 10, 2012 6:29 am
- Location: Glendale, California
Re: Adding a framework changes 1000 lines
by TheVinn » Sat Jun 16, 2012 1:59 am
I have core.autocrlf set to true
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by bdejong » Wed Jun 20, 2012 4:25 pm
Are you perhaps mixing using the Introjucer on mac and on pc? 
- bram
- bram
- bdejong
- JUCE UberWeenie
- Posts: 282
- Joined: Wed Sep 28, 2011 1:30 pm
Re: Adding a framework changes 1000 lines
by TheVinn » Wed Jun 20, 2012 4:33 pm
bdejong wrote:Are you perhaps mixing using the Introjucer on mac and on pc?
Yep...
Open Source: LayerEffects, VFLib, SimpleDJ, DSP Filters, LuaBridge, JUCE, FreeType, TagLib
"This isn't a big project, it shouldn't take long." - Jules
"This isn't a big project, it shouldn't take long." - Jules
-
TheVinn - JUCE UberWeenie
- Posts: 2989
- Joined: Sat Aug 29, 2009 11:31 am
- Location: Marina del Rey, California
Re: Adding a framework changes 1000 lines
by bdejong » Wed Jun 20, 2012 5:05 pm
there you go...
osx and windows version of the introjucer generate different endlines!
I flagged this before, ...
- bram
osx and windows version of the introjucer generate different endlines!
I flagged this before, ...
- bram
- bdejong
- JUCE UberWeenie
- Posts: 282
- Joined: Wed Sep 28, 2011 1:30 pm
17 posts
• Page 1 of 2 • 1, 2
Return to The Introjucer/Jucer
Who is online
Users browsing this forum: No registered users and 2 guests