TextPropLabel backgroundColourId

Discussion and support for general JUCE issues

TextPropLabel backgroundColourId

Postby Graeme » Wed Jun 20, 2012 9:43 pm

Hi Jules, can you change the following constructor to not have a hard coded value for the backgroundColourId?

Code: Select all
    TextPropLabel (TextPropertyComponent& owner_,
                   const int maxChars_, const bool isMultiline_)
        : Label (String::empty, String::empty),
          owner (owner_),
          maxChars (maxChars_),
          isMultiline (isMultiline_)
    {
        setEditable (true, true, false);

        setColour (backgroundColourId, Colours::white);
        setColour (outlineColourId, findColour (ComboBox::outlineColourId));
    }
User avatar
Graeme
JUCE UberWeenie
 
Posts: 194
Joined: Fri Jan 07, 2011 8:37 pm

Re: TextPropLabel backgroundColourId

Postby jules » Thu Jun 21, 2012 12:14 pm

Yeah, I guess that colour should be the same as the ComboBox::backgroundColourId. Although... I'm not sure why I hard-coded it like that, there might actually have been a good reason which I can't currently remember..
User avatar
jules
Fearless Leader
 
Posts: 17373
Joined: Mon Sep 06, 2004 9:03 am
Location: London, UK

Re: TextPropLabel backgroundColourId

Postby Graeme » Fri Jul 27, 2012 8:30 pm

Hi Jules. Shouldn't the colour id's here be the ones from Label instead of ComboBox?
User avatar
Graeme
JUCE UberWeenie
 
Posts: 194
Joined: Fri Jan 07, 2011 8:37 pm

Re: TextPropLabel backgroundColourId

Postby jules » Fri Jul 27, 2012 9:57 pm

Yes, they should! Thanks!
User avatar
jules
Fearless Leader
 
Posts: 17373
Joined: Mon Sep 06, 2004 9:03 am
Location: London, UK


Return to General JUCE discussion

Who is online

Users browsing this forum: Bing [Bot], Google [Bot], Google Feedfetcher and 3 guests

cron